From 4e65c30e18957fbe9dec519788182475830a4fb9 Mon Sep 17 00:00:00 2001 From: Josh Avant Date: Mon, 9 Jan 2023 19:50:49 -0600 Subject: [PATCH] fix: Parameterize Stripe Payment Fee configs (#6024) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * Parameterize Stripe Payment Fee configs * Restore constant values for Payment Fee params * Restore constant values for all Payment Fee params * Remove STRIPE_ prefix on payment fee vars * Cast Payment Fee params as Number Co-authored-by: Peer Richelsen Co-authored-by: Joe Au-Yeung <65426560+joeauyeung@users.noreply.github.com> Co-authored-by: Omar López --- .env.example | 2 ++ packages/prisma/seed-app-store.ts | 8 +++++--- turbo.json | 2 ++ 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/.env.example b/.env.example index 294cc6168c..7f5d7ecc70 100644 --- a/.env.example +++ b/.env.example @@ -102,6 +102,8 @@ STRIPE_TEAM_MONTHLY_PRICE_ID= STRIPE_WEBHOOK_SECRET= STRIPE_PRIVATE_KEY= STRIPE_CLIENT_ID= +PAYMENT_FEE_FIXED= +PAYMENT_FEE_PERCENTAGE= # Use for internal Public API Keys and optional API_KEY_PREFIX=cal_ diff --git a/packages/prisma/seed-app-store.ts b/packages/prisma/seed-app-store.ts index d22f5aada2..5bc0b877d7 100644 --- a/packages/prisma/seed-app-store.ts +++ b/packages/prisma/seed-app-store.ts @@ -274,13 +274,15 @@ export default async function main() { process.env.STRIPE_CLIENT_ID && process.env.STRIPE_PRIVATE_KEY && process.env.NEXT_PUBLIC_STRIPE_PUBLIC_KEY && - process.env.STRIPE_WEBHOOK_SECRET + process.env.STRIPE_WEBHOOK_SECRET && + process.env.PAYMENT_FEE_FIXED && + process.env.PAYMENT_FEE_PERCENTAGE ) { await createApp("stripe", "stripepayment", ["payment"], "stripe_payment", { client_id: process.env.STRIPE_CLIENT_ID, client_secret: process.env.STRIPE_PRIVATE_KEY, - payment_fee_fixed: 10, - payment_fee_percentage: 0.005, + payment_fee_fixed: Number(process.env.PAYMENT_FEE_FIXED), + payment_fee_percentage: Number(process.env.PAYMENT_FEE_PERCENTAGE), public_key: process.env.NEXT_PUBLIC_STRIPE_PUBLIC_KEY, webhook_secret: process.env.STRIPE_WEBHOOK_SECRET, }); diff --git a/turbo.json b/turbo.json index 174dc4843c..22b0794405 100644 --- a/turbo.json +++ b/turbo.json @@ -247,6 +247,8 @@ "$STRIPE_CLIENT_ID", "$STRIPE_PRIVATE_KEY", "$STRIPE_WEBHOOK_SECRET", + "$PAYMENT_FEE_FIXED", + "$PAYMENT_FEE_PERCENTAGE", "$TELEMETRY_DEBUG", "$VERCEL_ENV", "$VERCEL_URL",