fix: Org invitation e2e flakiness (#12861)

This commit is contained in:
Hariom Balhara 2023-12-19 13:04:15 +05:30 committed by GitHub
parent a8d9b0210a
commit 5fb1857538
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 14 additions and 2 deletions

View File

@ -75,6 +75,7 @@ function UsernameField({
setUsernameTaken,
orgSlug,
usernameTaken,
disabled,
...props
}: React.ComponentProps<typeof TextField> & {
username: string;
@ -92,6 +93,8 @@ function UsernameField({
if (formState.isSubmitting || formState.isSubmitSuccessful) return;
async function checkUsername() {
// If the username can't be changed, there is no point in doing the username availability check
if (disabled) return;
if (!debouncedUsername) {
setPremium(false);
setUsernameTaken(false);
@ -103,11 +106,20 @@ function UsernameField({
});
}
checkUsername();
}, [debouncedUsername, setPremium, setUsernameTaken, formState.isSubmitting, formState.isSubmitSuccessful]);
}, [
debouncedUsername,
setPremium,
disabled,
orgSlug,
setUsernameTaken,
formState.isSubmitting,
formState.isSubmitSuccessful,
]);
return (
<div>
<TextField
disabled={disabled}
{...props}
{...register("username")}
data-testid="signup-usernamefield"

View File

@ -392,7 +392,7 @@ async function signupFromEmailInviteLink({
const signupPage = await context.newPage();
signupPage.goto(inviteLink);
await signupPage.waitForLoadState("networkidle");
await signupPage.locator(`[data-testid="signup-usernamefield"]`).waitFor({ state: "visible" });
await expect(signupPage.locator(`[data-testid="signup-usernamefield"]`)).toBeDisabled();
expect(await signupPage.locator(`[data-testid="signup-usernamefield"]`).inputValue()).toBe(
expectedUsername