maronato/cal
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Refactor

This commit is contained in:
gitstart-calcom 2023-11-28 20:18:33 +00:00
parent b26d66f1c6
commit 654312ceb2
2 changed files with 16 additions and 44 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
apps/web/playwright/booking/regularEventType/questions/allQuestions.e2e.ts
View File

@ -12,20 +12,21 @@ test.describe("Booking With All Questions", () => {
const bookingOptions = { isAllRequired: true };
const allQuestions = [
"phone",
"address",
"checkbox",
"boolean",
"textarea",
"multiemail",
"multiselect",
"number",
"radio",
"select",
"text",
];
test("Selecting and filling all questions as required", async ({ bookingPage }) => {
const allQuestions = [
"phone",
"address",
"checkbox",
"boolean",
"textarea",
"multiemail",
"multiselect",
"number",
"radio",
"select",
"text",
];
for (const question of allQuestions) {
if (
question !== "number" &&
@ -59,19 +60,6 @@ test.describe("Booking With All Questions", () => {
});
test("Selecting and filling all questions as optional", async ({ bookingPage }) => {
const allQuestions = [
"phone",
"address",
"checkbox",
"boolean",
"textarea",
"multiemail",
"multiselect",
"number",
"radio",
"select",
"text",
];
for (const question of allQuestions) {
if (
question !== "number" &&
@ -91,7 +79,7 @@ test.describe("Booking With All Questions", () => {
} else {
await bookingPage.addQuestion(question, `${question}-test`, `${question} test`, false);
}
await bookingPage.checkField(question);
await bookingPage.checkField(question, { isOptional: true });
}
await bookingPage.updateEventType();

18
apps/web/playwright/fixtures/regularBookings.ts
View File

@ -286,14 +286,6 @@ export function createBookingPageFixture(page: Page) {
await eventTypePage.getByPlaceholder(reschedulePlaceholderText).click();
await eventTypePage.getByPlaceholder(reschedulePlaceholderText).fill("Test reschedule");
await eventTypePage.getByTestId("confirm-reschedule-button").click();
await eventTypePage.waitForTimeout(400);
if (
await eventTypePage.getByRole("heading", { name: "Could not reschedule the meeting." }).isVisible()
) {
await eventTypePage.getByTestId("back").click();
await eventTypePage.getByTestId("time").last().click();
await eventTypePage.getByTestId("confirm-reschedule-button").click();
}
},
assertBookingRescheduled: async (page: Page) => {
@ -348,14 +340,6 @@ export function createBookingPageFixture(page: Page) {
options.isRequired && (await fillQuestion(eventTypePage, secondQuestion, customLocators));
await eventTypePage.getByTestId(confirmButton).click();
await eventTypePage.waitForTimeout(400);
if (await eventTypePage.getByRole("heading", { name: "Could not book the meeting." }).isVisible()) {
await eventTypePage.getByTestId("back").click();
await eventTypePage.getByTestId("time").last().click();
await fillQuestion(eventTypePage, question, customLocators);
options.isRequired && (await fillQuestion(eventTypePage, secondQuestion, customLocators));
await eventTypePage.getByTestId(confirmButton).click();
}
const scheduleSuccessfullyPage = eventTypePage.getByText(scheduleSuccessfullyText);
await scheduleSuccessfullyPage.waitFor({ state: "visible" });
await expect(scheduleSuccessfullyPage).toBeVisible();
@ -462,7 +446,7 @@ export function createBookingPageFixture(page: Page) {
const deleteManagedEventTypeDescription = (await localize("en"))(
"delete_managed_event_type_description"
);
const confirmDeleteEventTypeText = (await localize("en"))("deleteManagedEventTypeDescription");
const confirmDeleteEventTypeText = (await localize("en"))("confirm_delete_event_type");
await expect(page.getByText(deleteManagedEventTypeDescription)).toBeVisible();
await page.getByRole("button", { name: confirmDeleteEventTypeText }).click();