maronato/cal
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

perf: [CAL-1928] Deduplicate eventTypes.getByViewer query (#9700) 

Co-authored-by: alannnc <alannnc@gmail.com>
Co-authored-by: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com>
This commit is contained in:
Afzal Sayed 2023-06-22 12:16:34 +04:00 committed by GitHub
parent 3e90c08d55
commit 79f34a4fc7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
apps/web/pages/event-types/index.tsx
View File

@ -861,7 +861,7 @@ const EventTypesPage = () => {
const filters = getTeamsFiltersFromQuery(router.query);
// eslint-disable-next-line @typescript-eslint/no-explicit-any
const WithQuery = withQuery(trpc.viewer.eventTypes.getByViewer as any, { filters });
const WithQuery = withQuery(trpc.viewer.eventTypes.getByViewer as any, filters && { filters });
return (
<div>

5
packages/features/filters/lib/getTeamsFiltersFromQuery.ts
View File

@ -24,5 +24,10 @@ export const getTeamsFiltersFromQuery = (query: ParsedUrlQuery) => {
// [1,2] is equivalent to [2,1] when fetching filter data.
filters.teamIds = filters.teamIds?.sort();
filters.userIds = filters.userIds?.sort();
if (!filters.teamIds?.length && !filters.userIds?.length) {
return undefined;
}
return filters;
};