Formatting

This commit is contained in:
zomars 2023-01-04 13:47:22 -07:00
parent e5a8a4e34d
commit bed798d440
3 changed files with 16 additions and 9 deletions

View File

@ -353,7 +353,6 @@ following
5. Use **Application (client) ID** as the **MS_GRAPH_CLIENT_ID** attribute value in .env
6. Click **Certificates & secrets** create a new client secret and use the value as the **MS_GRAPH_CLIENT_SECRET** attribute
### Obtaining Zoom Client ID and Secret
1. Open [Zoom Marketplace](https://marketplace.zoom.us/) and sign in with your Zoom account.

View File

@ -31,7 +31,7 @@ And from another terminal you can run the following command to execute tests:
yarn embed-tests-quick
```
Note: `getEmbedIframe` and `addEmbedListeners` work as a team but they only support opening up embed in a fresh load. Opening an embed closing it and then opening another embed isn't supported yet.
Note: `getEmbedIframe` and `addEmbedListeners` work as a team but they only support opening up embed in a fresh load. Opening an embed closing it and then opening another embed isn't supported yet.
## Shipping to Production

View File

@ -3,25 +3,33 @@
We're currently in the progress of merging multiple versions of our UI library into one new version.
## Version 1
Anything version 1 is in the root, or in the root folders skeleton, form, booker and apps.
## Version 2
Anything version 2 is in the v2 folder
## New version
We're currently creating all new components following new standards in the components directory. The /styles directory contains the shared tailwind styles.
### Adding new components
For adding new components it is important to take a few patterns into account:
* All components should be added in /components
* All components should be in a folder, no tsx files directly in the root
* All components should contain stories and MDX documentation (which is why they can't live in the root, since that would result in a lot of duplication)
- All components should be added in /components
- All components should be in a folder, no tsx files directly in the root
- All components should contain stories and MDX documentation (which is why they can't live in the root, since that would result in a lot of duplication)
### Migration process
We're currently migrating existing components step by step, this process looks as following:
* New components only should get added in /components
* Any existing components in v2 are reviewed, updated if needed and then moved to the /components directory
* After v2 is moved, the old v2 component should be deleted, as well as any v1 version of that component. All places in the monorepo where we use this component, should use the newest version by then.
- New components only should get added in /components
- Any existing components in v2 are reviewed, updated if needed and then moved to the /components directory
- After v2 is moved, the old v2 component should be deleted, as well as any v1 version of that component. All places in the monorepo where we use this component, should use the newest version by then.
### End state
The envisioned end state is a state where only the /components directory exists. In this directory all components should have documentation and stories.
The envisioned end state is a state where only the /components directory exists. In this directory all components should have documentation and stories.