From c3537f32907815a090be69571247aaa237b0298c Mon Sep 17 00:00:00 2001 From: Lauris Skraucis Date: Wed, 1 Nov 2023 15:52:11 +0100 Subject: [PATCH] docs: needs approval label (#12177) Our CI workflow doesn't allow merging for only .md changes because the required check doesn't clear based on file filters. --- .github/ISSUE_TEMPLATE/feature_request.md | 6 ++++++ .github/PULL_REQUEST_TEMPLATE.md | 2 +- CONTRIBUTING.md | 13 ++++++++++++- 3 files changed, 19 insertions(+), 2 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/feature_request.md b/.github/ISSUE_TEMPLATE/feature_request.md index 0040d6d364..7c266e0957 100644 --- a/.github/ISSUE_TEMPLATE/feature_request.md +++ b/.github/ISSUE_TEMPLATE/feature_request.md @@ -47,3 +47,9 @@ assignees: "" --> (Share it here.) + +--- +##### House rules +- If this issue has a `🚨 needs approval` label, don't start coding yet. Wait until a core member approves feature request by removing this label, then you can start coding. + - For clarity: Non-core member issues automatically get the `🚨 needs approval` label. + - Your feature ideas are invaluable to us! However, they undergo review to ensure alignment with the product's direction. diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 2ef5c789ea..0b19591ddd 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -40,7 +40,7 @@ Fixes # (issue) ## Checklist - + - I haven't read the [contributing guide](https://github.com/calcom/cal.com/blob/main/CONTRIBUTING.md) - My code doesn't follow the style guidelines of this project diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 520107e0dc..eb52da8d6f 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -2,7 +2,18 @@ Contributions are what makes the open source community such an amazing place to learn, inspire, and create. Any contributions you make are **greatly appreciated**. -- Before jumping into a PR be sure to search [existing PRs](https://github.com/calcom/cal.com/pulls) or [issues](https://github.com/calcom/cal.com/issues) for an open or closed item that relates to your submission. +## House rules + +- Before submitting a new issue or PR, check if it already exists in [issues](https://github.com/calcom/cal.com/issues) or [PRs](https://github.com/calcom/cal.com/pulls). +- GitHub issues: take note of the `🚨 needs approval` label. + - **For Contributors**: + - Feature Requests: Wait for a core member to approve and remove the `🚨 needs approval` label before you start coding or submit a PR. + - Bugs, Security, Performance, Documentation, etc.: You can start coding immediately, even if the `🚨 needs approval` label is present. This label mainly concerns feature requests. + - **Our Process**: + - Issues from non-core members automatically receive the `🚨 needs approval` label. + - We greatly value new feature ideas. To ensure consistency in the product's direction, they undergo review and approval. + + ## Priorities