From e248dfbda787144390fbdc8ed72b92aaaf90a0f9 Mon Sep 17 00:00:00 2001 From: DmytroHryshyn <125881252+DmytroHryshyn@users.noreply.github.com> Date: Tue, 19 Dec 2023 23:58:33 +0200 Subject: [PATCH] chore: [app-router-migration-8.5]: add a/b test flags for apps, workflows, getting-started, settings/teams (#12797) * add a/b test flags for apps, workflows, getting-started, settings/teams * fix linter * fix * fix --------- Co-authored-by: zomars --- .env.example | 4 ++++ apps/web/abTest/middlewareFactory.ts | 4 ++++ apps/web/middleware.ts | 8 ++++++++ turbo.json | 6 +++++- 4 files changed, 21 insertions(+), 1 deletion(-) diff --git a/.env.example b/.env.example index a2b9ae1742..204be5fe9d 100644 --- a/.env.example +++ b/.env.example @@ -315,4 +315,8 @@ APP_ROUTER_APPS_CATEGORIES_ENABLED=0 # whether we redirect to the future/apps/categories/[category] from /apps/categories/[category] or not APP_ROUTER_APPS_CATEGORIES_CATEGORY_ENABLED=0 APP_ROUTER_BOOKINGS_STATUS_ENABLED=0 +APP_ROUTER_WORKFLOWS_ENABLED=0 +APP_ROUTER_SETTINGS_TEAMS_ENABLED=0 +APP_ROUTER_GETTING_STARTED_STEP_ENABLED=0 +APP_ROUTER_APPS_ENABLED=0 APP_ROUTER_VIDEO_ENABLED=0 diff --git a/apps/web/abTest/middlewareFactory.ts b/apps/web/abTest/middlewareFactory.ts index 66d29c0dd3..7c2cf36832 100644 --- a/apps/web/abTest/middlewareFactory.ts +++ b/apps/web/abTest/middlewareFactory.ts @@ -11,6 +11,10 @@ const ROUTES: [URLPattern, boolean][] = [ ["/apps/:slug/setup", process.env.APP_ROUTER_APPS_SLUG_SETUP_ENABLED === "1"] as const, ["/apps/categories", process.env.APP_ROUTER_APPS_CATEGORIES_ENABLED === "1"] as const, ["/apps/categories/:category", process.env.APP_ROUTER_APPS_CATEGORIES_CATEGORY_ENABLED === "1"] as const, + ["/workflows/:path*", process.env.APP_ROUTER_WORKFLOWS_ENABLED === "1"] as const, + ["/settings/teams/:path*", process.env.APP_ROUTER_SETTINGS_TEAMS_ENABLED === "1"] as const, + ["/getting-started/:step", process.env.APP_ROUTER_GETTING_STARTED_STEP_ENABLED === "1"] as const, + ["/apps", process.env.APP_ROUTER_APPS_ENABLED === "1"] as const, ["/bookings/:status", process.env.APP_ROUTER_BOOKINGS_STATUS_ENABLED === "1"] as const, ["/video/:path*", process.env.APP_ROUTER_VIDEO_ENABLED === "1"] as const, ].map(([pathname, enabled]) => [ diff --git a/apps/web/middleware.ts b/apps/web/middleware.ts index c20a39b76e..c2025b14d7 100644 --- a/apps/web/middleware.ts +++ b/apps/web/middleware.ts @@ -130,6 +130,14 @@ export const config = { "/future/apps/categories/", "/apps/categories/:category/", "/future/apps/categories/:category/", + "/workflows/:path*", + "/future/workflows/:path*", + "/settings/teams/:path*", + "/future/settings/teams/:path*", + "/getting-started/:step/", + "/future/getting-started/:step/", + "/apps", + "/future/apps", "/bookings/:status/", "/future/bookings/:status/", "/video/:path*", diff --git a/turbo.json b/turbo.json index 0c16762a39..250cca10cf 100644 --- a/turbo.json +++ b/turbo.json @@ -198,14 +198,18 @@ "ALLOWED_HOSTNAMES", "ANALYZE", "API_KEY_PREFIX", - "APP_ROUTER_APPS_INSTALLED_CATEGORY_ENABLED", "APP_ROUTER_APPS_CATEGORIES_CATEGORY_ENABLED", "APP_ROUTER_APPS_CATEGORIES_ENABLED", + "APP_ROUTER_APPS_ENABLED", + "APP_ROUTER_APPS_INSTALLED_CATEGORY_ENABLED", "APP_ROUTER_APPS_SLUG_ENABLED", "APP_ROUTER_APPS_SLUG_SETUP_ENABLED", "APP_ROUTER_BOOKINGS_STATUS_ENABLED", "APP_ROUTER_EVENT_TYPES_ENABLED", + "APP_ROUTER_GETTING_STARTED_STEP_ENABLED", "APP_ROUTER_SETTINGS_ADMIN_ENABLED", + "APP_ROUTER_SETTINGS_TEAMS_ENABLED", + "APP_ROUTER_WORKFLOWS_ENABLED", "APP_ROUTER_VIDEO_ENABLED", "APP_USER_NAME", "BASECAMP3_CLIENT_ID",